[#1736] feat(postgresql): Support PostgreSQL index. #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANNG1
reviewed
Jan 30, 2024
...in/java/com/datastrato/gravitino/catalog/postgresql/operation/PostgreSqlTableOperations.java
Outdated
Show resolved
Hide resolved
Clearvive
force-pushed
the
add-pg-index
branch
from
dc3a438 to
5ab650b
Compare
FANNG1
reviewed
Jan 31, 2024
...strato/gravitino/integration/test/catalog/jdbc/postgresql/TestPostgreSqlTableOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 31, 2024
...strato/gravitino/integration/test/catalog/jdbc/postgresql/TestPostgreSqlTableOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 31, 2024
...in/java/com/datastrato/gravitino/catalog/postgresql/operation/PostgreSqlTableOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 31, 2024
.../java/com/datastrato/gravitino/catalog/postgresql/operation/UTPostgreSqlTableOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 31, 2024
...a/com/datastrato/gravitino/integration/test/catalog/jdbc/postgresql/CatalogPostgreSqlIT.java
Show resolved
Hide resolved
FANNG1
reviewed
Jan 31, 2024
FANNG1
reviewed
Jan 31, 2024
...a/com/datastrato/gravitino/integration/test/catalog/jdbc/postgresql/CatalogPostgreSqlIT.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 31, 2024
...a/com/datastrato/gravitino/integration/test/catalog/jdbc/postgresql/CatalogPostgreSqlIT.java
Show resolved
Hide resolved
FANNG1
reviewed
Jan 31, 2024
FANNG1
reviewed
Jan 31, 2024
...ommon/src/main/java/com/datastrato/gravitino/catalog/jdbc/operation/JdbcTableOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 31, 2024
...ommon/src/main/java/com/datastrato/gravitino/catalog/jdbc/operation/JdbcTableOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 31, 2024
...ommon/src/main/java/com/datastrato/gravitino/catalog/jdbc/operation/JdbcTableOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 31, 2024
...alog-jdbc-common/src/main/java/com/datastrato/gravitino/catalog/jdbc/bean/JdbcIndexBean.java
Show resolved
Hide resolved
FANNG1
reviewed
Jan 31, 2024
...com/datastrato/gravitino/catalog/postgresql/operation/UnitTestPostgreSqlTableOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 31, 2024
...a/com/datastrato/gravitino/integration/test/catalog/jdbc/postgresql/CatalogPostgreSqlIT.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 31, 2024
...ommon/src/main/java/com/datastrato/gravitino/catalog/jdbc/operation/JdbcTableOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 31, 2024
...ommon/src/main/java/com/datastrato/gravitino/catalog/jdbc/operation/JdbcTableOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 31, 2024
...ommon/src/main/java/com/datastrato/gravitino/catalog/jdbc/operation/JdbcTableOperations.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 31, 2024
...com/datastrato/gravitino/catalog/postgresql/operation/UnitTestPostgreSqlTableOperations.java
Outdated
Show resolved
Hide resolved
Clearvive
force-pushed
the
add-pg-index
branch
from
17131ec to
204ae9a
Compare
FANNG1
reviewed
Jan 31, 2024
...c/test/java/com/datastrato/gravitino/integration/test/catalog/jdbc/mysql/CatalogMysqlIT.java
Show resolved
Hide resolved
FANNG1
reviewed
Jan 31, 2024
...ommon/src/main/java/com/datastrato/gravitino/catalog/jdbc/operation/JdbcTableOperations.java
Show resolved
Hide resolved
|
LGTM except the comment |
FANNG1
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support PostgreSQL index.
Why are the changes needed?
Fix: #1736
Does this PR introduce any user-facing change?
NO
How was this patch tested?
UT/IT